Pipe: aggregate tablets with different measurements under the same device before write into tsfile#15193
Merged
SteveYurongSu merged 7 commits intoapache:masterfrom Apr 17, 2025
Merged
Conversation
Member
|
@luoluoyuyu PTAL |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces logic to aggregate tablets with matching measurement criteria before writing them into tsfiles, which is aimed at optimizing the writing process for devices with various measurement data.
- Added a new method, tryBestToAggregateTablets, to aggregate tablets while maintaining consistent timestamps, row sizes, and maximum row numbers.
- Updated the logic in tryBestToWriteTabletsIntoOneFile to leverage tablet aggregation.
- Streamlined lambda expressions in integration tests for both push and pull consumer scenarios.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/util/builder/PipeTreeModelTsFileBuilder.java | Added aggregation logic and incorporated it into the tablet writing process. |
| integration-test/src/test/java/org/apache/iotdb/subscription/it/triple/regression/pushconsumer/multi/IoTDBConsumer2With1TopicShareProcessTsfileIT.java | Simplified lambda assertion blocks. |
| integration-test/src/test/java/org/apache/iotdb/subscription/it/triple/regression/pullconsumer/multi/IoTDBConsumer2With1TopicShareProcessTsfileIT.java | Simplified lambda assertion blocks. |
Comments suppressed due to low confidence (1)
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/util/builder/PipeTreeModelTsFileBuilder.java:199
- [nitpick] Consider renaming the method tryBestToAggregateTablets to a more descriptive name such as aggregateTabletsMatchingCriteria to better convey its purpose.
private Tablet tryBestToAggregateTablets(
SteveYurongSu
approved these changes
Apr 17, 2025
VGalaxies
added a commit
to VGalaxies/iotdb
that referenced
this pull request
Apr 17, 2025
…vice before write into tsfile (apache#15193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.