Skip to content

feat: update to jdk17 and javax migration to jakarta#15239

Open
CritasWang wants to merge 3 commits intomasterfrom
wx_jdk17
Open

feat: update to jdk17 and javax migration to jakarta#15239
CritasWang wants to merge 3 commits intomasterfrom
wx_jdk17

Conversation

@CritasWang
Copy link
Collaborator

No description provided.

@CritasWang CritasWang requested a review from Copilot March 31, 2025 09:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to support JDK17 by migrating all relevant imports from javax to jakarta and updating the project version.

  • Migrates servlet, JAX-RS, validation, and annotation imports from javax to jakarta.
  • Updates the project version in the pyproject.toml file.
  • Ensures consistency in configuration across core, confignode, and integration test modules.

Reviewed Changes

Copilot reviewed 195 out of 198 changed files in this pull request and generated no comments.

Show a summary per file
File Description
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/filter/AuthorizationFilter.java Migrates servlet and JAX-RS imports from javax to jakarta.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/filter/ApiOriginFilter.java Migrates servlet imports from javax to jakarta.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/PipeInsertionEvent.java Updates validation constraint imports from javax to jakarta.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/audit/AuditLogger.java Migrates validation annotations to jakarta and removes duplicate javax imports.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/schema/table/DeleteDevicesProcedure.java Updates annotation imports from javax to jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/mnode/container/ConfigMNodeContainer.java Replaces javax validation annotations with jakarta equivalents.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/CNPhysicalPlanGenerator.java Migrates annotation imports from javax to jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaQuotaStatistics.java Updates validation imports to jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java Replaces javax annotation imports with jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/response/cq/ShowCQResp.java Updates validation constraint import from javax to jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/pipe/payload/PipeDeleteTimeSeriesPlan.java Migrates nonnull annotation import to jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/pipe/payload/PipeDeleteLogicalViewPlan.java Migrates nonnull annotation import to jakarta.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/pipe/payload/PipeDeleteDevicesPlan.java Migrates nonnull annotation import to jakarta.
iotdb-core/ainode/pyproject.toml Updates the project version to reflect recent development.
integration-test/src/main/java/org/apache/iotdb/it/env/cluster/node/AbstractNodeWrapper.java Updates annotation for nullable from javax to jakarta.
integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppJVMConfig.java Replaces javax nullable annotation with jakarta.
integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppBaseConfig.java Migrates nullable and validation annotations from javax to jakarta.
Files not reviewed (3)
  • integration-test/pom.xml: Language not supported
  • iotdb-core/confignode/pom.xml: Language not supported
  • iotdb-core/datanode/pom.xml: Language not supported

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.39%. Comparing base (9b406e1) to head (538b912).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...iotdb/db/protocol/rest/filter/ApiOriginFilter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15239      +/-   ##
============================================
- Coverage     39.41%   39.39%   -0.02%     
  Complexity      193      193              
============================================
  Files          4624     4624              
  Lines        297744   297787      +43     
  Branches      37166    37174       +8     
============================================
- Hits         117356   117327      -29     
- Misses       180388   180460      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants