Skip to content

Pipe: use mem table to batch write tree data into tsfile#15276

Merged
SteveYurongSu merged 14 commits intoapache:masterfrom
VGalaxies:tree-tsfile-builder
Apr 17, 2025
Merged

Pipe: use mem table to batch write tree data into tsfile#15276
SteveYurongSu merged 14 commits intoapache:masterfrom
VGalaxies:tree-tsfile-builder

Conversation

@VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Apr 5, 2025

As title.

@SteveYurongSu SteveYurongSu requested a review from Copilot April 7, 2025 02:13
@SteveYurongSu SteveYurongSu self-assigned this Apr 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

integration-test/src/test/java/org/apache/iotdb/subscription/it/triple/regression/pushconsumer/pattern/IoTDBTSPatternTsfilePushConsumerIT.java:205

  • The assertion has been relaxed from expecting exactly 1 file to a greater-or-equal condition; confirm if this change accurately reflects the intended behavior in the test scenario.
          assertGte(onReceiveCount.get(), 1, "receive files over 1");

integration-test/src/test/java/org/apache/iotdb/subscription/it/triple/regression/pullconsumer/multi/IoTDBConsumer2With1TopicShareProcessTsfileIT.java:192

  • Changing the assertion to check for a count greater than or equal to 0 may not strictly verify the expected outcome; verify that this relaxed condition aligns with the intended test behavior.
          assertGte(rowCount1.get(), 0);

@VGalaxies VGalaxies marked this pull request as ready for review April 10, 2025 09:21
@SteveYurongSu SteveYurongSu merged commit a84bee7 into apache:master Apr 17, 2025
49 of 50 checks passed
@VGalaxies VGalaxies deleted the tree-tsfile-builder branch April 17, 2025 04:40
VGalaxies added a commit to VGalaxies/iotdb that referenced this pull request Apr 17, 2025
SteveYurongSu pushed a commit that referenced this pull request Apr 21, 2025
* Pipe: use mem table to batch write tree data into tsfile (#15276)

* fixup
JackieTien97 pushed a commit that referenced this pull request May 14, 2025
Caideyipi pushed a commit to Caideyipi/iotdb that referenced this pull request Mar 25, 2026
…pache#15353)

* Pipe: use mem table to batch write tree data into tsfile (apache#15276)

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants