Skip to content

Fixed the concurrent modification bug of pathPatternTree#15280

Merged
JackieTien97 merged 1 commit intoapache:masterfrom
Caideyipi:concurrent-mode
Apr 14, 2025
Merged

Fixed the concurrent modification bug of pathPatternTree#15280
JackieTien97 merged 1 commit intoapache:masterfrom
Caideyipi:concurrent-mode

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Apr 7, 2025

Description

As the title said.

Abnormal phenomenon:
img_v3_02l4_a7b23c89-979d-495c-ae1e-bff08e65ea2g

Analysis:
The "pathPatternList" in "PathPatternTree" May be concurrently read and write:
Read: "getOverlappedPathPatterns()" in IoTDB-ConfigNodeRPC-Processor
Write: "clear()" --> "constructTree()" --> "serialize()" --> "preparePatternTreeBytesData()" --> "executeDeleteData()" in "DeleteTimeSeriesProcedure" in ProcedureCoreWorker


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@JackieTien97 JackieTien97 merged commit 5354dee into apache:master Apr 14, 2025
49 of 50 checks passed
@Caideyipi Caideyipi deleted the concurrent-mode branch April 14, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants