Skip to content

Do not add new compaction mod file in deletion#15281

Merged
jt2594838 merged 4 commits intomasterfrom
no_new_compaction_mods
Apr 11, 2025
Merged

Do not add new compaction mod file in deletion#15281
jt2594838 merged 4 commits intomasterfrom
no_new_compaction_mods

Conversation

@jt2594838
Copy link
Contributor

The old mechanism uses a "compaction mod file" to record deletions during compaction and merge them into the modification file of the compacted file.
However, this encounters concurrent issues during the process of "merging deletions into the modification file of the compacted file".
Therefore, it is replaced with the new mechanism using cascading modification files to write deletions during compaction also to the compacted files' modification file.

For compatibility with systems that have already generated compaction mods, the old mechanism is kept to handle the recovery and deletion of the compaction mods.
But no new compaction mods should be created, which is to be fixed in this PR.

This also avoids meeting null compaction mods during deletion because after exiting the synchronized block below, the compaction mods may just be set to null by compaction.
image

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.40%. Comparing base (e4e3c29) to head (8778a4a).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15281      +/-   ##
============================================
+ Coverage     39.37%   39.40%   +0.02%     
  Complexity      193      193              
============================================
  Files          4637     4638       +1     
  Lines        298744   298981     +237     
  Branches      37276    37321      +45     
============================================
+ Hits         117638   117799     +161     
- Misses       181106   181182      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit d1d5f7f into master Apr 11, 2025
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants