Skip to content

refactor: load max page&chunk configuration in ReadOnlyMemchunk and M…#15309

Merged
jt2594838 merged 2 commits intoapache:masterfrom
shizy818:max_page_chunk
Apr 18, 2025
Merged

refactor: load max page&chunk configuration in ReadOnlyMemchunk and M…#15309
jt2594838 merged 2 commits intoapache:masterfrom
shizy818:max_page_chunk

Conversation

@shizy818
Copy link
Copy Markdown
Contributor

…emTableFlushTask

  1. load MAX_NUMBER_OF_POINTS_IN_PAGE config in ReadOnlyMemChunk. It is used by nextBatch method of iterators.
  2. load MAX_NUMBER_OF_POINTS_IN_PAGE, MAX_NUMBER_OF_POINTS_IN_CHUNK & TARGET_CHUNK_SIZE config in MemTableFlushTask and save in BatchEncodeInfo object. They're used by encodeBatch method of iterators.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@jt2594838 jt2594838 merged commit 040f3af into apache:master Apr 18, 2025
50 checks passed
JackieTien97 pushed a commit that referenced this pull request May 14, 2025
#15309)

* refactor: load max page&chunk configuration in ReadOnlyMemchunk and MemTableFlushTask

* bug: fix testFlushMultiAlignedBinaryChunks

(cherry picked from commit 040f3af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants