Subscription: detect outdated subscription event for better consumer exception control#15326
Merged
SteveYurongSu merged 2 commits intoapache:masterfrom Apr 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java:1022
- [nitpick] Verify that comparing the payload with ErrorPayload.OUTDATED_ERROR_PAYLOAD using Objects.equals relies on reference equality as intended. If a different instance is ever used for outdated errors, this check may fail.
if (Objects.equals(payload, ErrorPayload.OUTDATED_ERROR_PAYLOAD)) {
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SubscriptionPrefetchingQueue.java:602
- [nitpick] Ensure that the assumption of commit IDs being monotonically increasing, as used in the outdated check, is documented and covered with unit tests to prevent potential misinterpretations in the future.
return PipeDataNodeAgent.runtime().getRebootTimes() > commitContext.getRebootTimes() || initialCommitId > commitContext.getCommitId();
SteveYurongSu
approved these changes
Apr 17, 2025
VGalaxies
added a commit
to VGalaxies/iotdb
that referenced
this pull request
Apr 17, 2025
…exception control (apache#15326)
Caideyipi
pushed a commit
to Caideyipi/iotdb
that referenced
this pull request
Mar 25, 2026
…exception control (apache#15326) (apache#15352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.