Skip to content

Skip generate distributed plan when treeDBName is null #15636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 3 commits into from
Jun 4, 2025
Merged

Skip generate distributed plan when treeDBName is null #15636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2503107
Skip generate distributed plan when treeDBName is null
shuwenwei Jun 3, 2025
f768dd4
fix it
shuwenwei Jun 3, 2025
2bcc9cd
fix compile
shuwenwei Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...src/test/java/org/apache/iotdb/relational/it/query/view/recent/IoTDBTableViewQueryIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,18 @@ public void test() throws Exception {
// empty result
compareQueryResults(
session, "select * from view3 limit 1", "select * from table1 limit 0", true);

// not exists
compareQueryResults(
session,
"select count(*) from view1 where battery = 'b'",
"select count(*) from table1 where battery = 'b'",
false);
compareQueryResults(
session,
"select * from (select time, battery as device1 from view1 where battery = 'b1') as t1 full outer join (select time, battery as device2 from view2 where battery = 'b') as t2 using(time)",
"select * from (select time, battery as device1 from table1 where battery = 'b1') as t1 full outer join (select time, battery as device2 from table1 where battery = 'b') as t2 using(time)",
true);
}
}

Expand Down
6 changes: 5 additions & 1 deletion ...otdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ private List<PlanNode> constructDeviceTableScanByRegionReplicaSet(
@Override
public List<PlanNode> visitTreeDeviceViewScan(TreeDeviceViewScanNode node, PlanContext context) {
DataPartition dataPartition = analysis.getDataPartitionInfo();
if (dataPartition == null) {
if (dataPartition == null || node.getTreeDBName() == null) {
node.setRegionReplicaSet(NOT_ASSIGNED);
return Collections.singletonList(node);
}
Expand Down Expand Up @@ -1025,6 +1025,10 @@ public List<PlanNode> visitAggregationTableScan(
node instanceof AggregationTreeDeviceViewScanNode
? ((AggregationTreeDeviceViewScanNode) node).getTreeDBName()
: node.getQualifiedObjectName().getDatabaseName();
if (dbName == null) {
node.setRegionReplicaSet(NOT_ASSIGNED);
return Collections.singletonList(node);
}
DataPartition dataPartition = analysis.getDataPartitionInfo();
boolean needSplit = false;
List<List<TRegionReplicaSet>> regionReplicaSetsList = new ArrayList<>();
Expand Down
Loading