Skip to content

Avoiding error log by removing ThreadLocal for Mqtt Client#15745

Merged
JackieTien97 merged 3 commits intomasterfrom
mqtt_bug
Jun 17, 2025
Merged

Avoiding error log by removing ThreadLocal for Mqtt Client#15745
JackieTien97 merged 3 commits intomasterfrom
mqtt_bug

Conversation

@JackieTien97
Copy link
Contributor

MQTT broker which IOTDB depended on is not a client-server 1 to 1 thread model, one server thread can serve multiple client connections and even one client connection can be served by different server threads.

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 39.12%. Comparing base (761f4e7) to head (003b4c6).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...nal/metadata/fetcher/TableDeviceSchemaFetcher.java 0.00% 8 Missing ⚠️
...ache/iotdb/db/protocol/session/SessionManager.java 0.00% 5 Missing ⚠️
...l/metadata/fetcher/TableDeviceSchemaValidator.java 0.00% 4 Missing ⚠️
...ache/iotdb/db/protocol/mqtt/MPPPublishHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15745      +/-   ##
============================================
- Coverage     39.12%   39.12%   -0.01%     
  Complexity      198      198              
============================================
  Files          4835     4835              
  Lines        314195   314391     +196     
  Branches      39406    39434      +28     
============================================
+ Hits         122943   123010      +67     
- Misses       191252   191381     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JackieTien97 JackieTien97 merged commit 8a8a7be into master Jun 17, 2025
59 of 60 checks passed
@JackieTien97 JackieTien97 deleted the mqtt_bug branch June 17, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant