Closed
Conversation
Closed
jt2594838
approved these changes
Sep 10, 2020
Contributor
jt2594838
left a comment
jt2594838
left a comment
There was a problem hiding this comment.
It is a good effort, but could our CI trigger it?
HTHou
reviewed
Sep 24, 2020
Contributor
HTHou
left a comment
HTHou
left a comment
There was a problem hiding this comment.
Please check the missing Apache headers. And I don't think it's necessary to include binary files in project.
Comment on lines
+1
to
+4
| from IoTDBConstants import TSDataType | ||
|
|
||
|
|
||
| class Field(object): |
Contributor
There was a problem hiding this comment.
This file is missing Apache header, please take a look.
Comment on lines
+1
to
+5
|
|
||
| from enum import Enum, unique | ||
|
|
||
|
|
||
| @unique |
Comment on lines
+1
to
+5
| import sys | ||
| from IoTDBConstants import * | ||
| sys.path.append("../../target") | ||
|
|
||
| from thrift.transport import TSocket, TTransport |
Comment on lines
+1
to
+6
| from IoTDBConstants import TSDataType | ||
| from Field import Field | ||
|
|
||
|
|
||
| class RowRecord(object): | ||
|
|
Comment on lines
+1
to
+5
|
|
||
| from IoTDBConstants import * | ||
| import struct | ||
|
|
||
|
|
Member
|
this PR will be closed because of #2539 However, the PR e2e test is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.