Skip to content

[To dev/1.3] Pipe: Fix and improve async tsfile transfer error handling and logging (avoid client connection leak)#16125

Merged
Caideyipi merged 1 commit intoapache:dev/1.3from
Caideyipi:handler-13
Aug 8, 2025
Merged

[To dev/1.3] Pipe: Fix and improve async tsfile transfer error handling and logging (avoid client connection leak)#16125
Caideyipi merged 1 commit intoapache:dev/1.3from
Caideyipi:handler-13

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

…g (avoid client connection leak) (apache#16008)

* Pipe: Fix and improve async tsfile transfer error handling and logging

Refactored IoTDBDataRegionAsyncConnector to handle exceptions during asynchronous tsfile transfer more gracefully. Now logs warnings instead of errors, invokes onError on the handler, and provides more context in log messages. Added getTsFile() method to PipeTransferTsFileHandler for better logging, and ensured memoryBlock is set to null after closing to prevent potential resource leaks.

* fix

* fix

* bald-logger

---------

Co-authored-by: Caideyipi <87789683+Caideyipi@users.noreply.github.com>
@Caideyipi Caideyipi merged commit b9c2124 into apache:dev/1.3 Aug 8, 2025
17 checks passed
@Caideyipi Caideyipi deleted the handler-13 branch August 8, 2025 04:06
Caideyipi added a commit to Caideyipi/iotdb that referenced this pull request Sep 2, 2025
…ng and logging (avoid client connection leak) (apache#16008) (apache#16125)

* Pipe: Fix and improve async tsfile transfer error handling and logging

Refactored IoTDBDataRegionAsyncConnector to handle exceptions during asynchronous tsfile transfer more gracefully. Now logs warnings instead of errors, invokes onError on the handler, and provides more context in log messages. Added getTsFile() method to PipeTransferTsFileHandler for better logging, and ensured memoryBlock is set to null after closing to prevent potential resource leaks.

* fix

* fix

* bald-logger

---------

Co-authored-by: Steve Yurong Su <rong@apache.org>
JackieTien97 pushed a commit that referenced this pull request Sep 2, 2025
…ng and logging (avoid client connection leak) (#16008) (#16125)

* Pipe: Fix and improve async tsfile transfer error handling and logging

Refactored IoTDBDataRegionAsyncConnector to handle exceptions during asynchronous tsfile transfer more gracefully. Now logs warnings instead of errors, invokes onError on the handler, and provides more context in log messages. Added getTsFile() method to PipeTransferTsFileHandler for better logging, and ensured memoryBlock is set to null after closing to prevent potential resource leaks.

* fix

* fix

* bald-logger

---------

Co-authored-by: Steve Yurong Su <rong@apache.org>
Caideyipi added a commit to Caideyipi/iotdb that referenced this pull request Mar 25, 2026
…ng and logging (avoid client connection leak) (apache#16008) (apache#16125)

* Pipe: Fix and improve async tsfile transfer error handling and logging

Refactored IoTDBDataRegionAsyncConnector to handle exceptions during asynchronous tsfile transfer more gracefully. Now logs warnings instead of errors, invokes onError on the handler, and provides more context in log messages. Added getTsFile() method to PipeTransferTsFileHandler for better logging, and ensured memoryBlock is set to null after closing to prevent potential resource leaks.

* fix

* fix

* bald-logger

---------

Co-authored-by: Steve Yurong Su <rong@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants