[AINode] Decoupling inference manager into request_manager, pool_manager#16131
Merged
CRZbulabula merged 6 commits intoapache:masterfrom Aug 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a major architectural refactoring that decouples the monolithic inference manager into separate, specialized components. The refactoring aims to improve maintainability and separation of concerns by creating distinct managers for different aspects of inference processing.
Key changes:
- Introduces a new
RequestManagerto handle request lifecycle and result processing - Adds a
PoolManagerto manage inference request pools and their states - Creates a
PoolSchedulerto handle pool initialization and expansion logic - Adds pool state tracking with a new
PoolStateenum andPoolGroupstructure
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| inference_manager.py | Refactored to delegate pool and request management to specialized components |
| request_manager.py | New component managing request lifecycle and result handling |
| pool_scheduler.py | New component handling pool initialization and expansion logic |
| pool_manager.py | New component managing pool registration, state tracking, and request dispatch |
| inference_request_pool_group.py | New data structure grouping pools by model ID |
| inference_request_pool.py | Added PoolState enum for state management |
| inference_request.py | Added model_id field to support request routing |
| decorator.py | Added synchronized decorator for thread safety |
44cee1d to
07292e4
Compare
97f6bc7 to
9a4b10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description