Skip to content

Supports streaming load mem chunk & Push down filter, limit and offset to MemPointIterator#16246

Merged
JackieTien97 merged 30 commits intomasterfrom
optimizeMemtableScan
Aug 29, 2025
Merged

Supports streaming load mem chunk & Push down filter, limit and offset to MemPointIterator#16246
JackieTien97 merged 30 commits intomasterfrom
optimizeMemtableScan

Conversation

@shuwenwei
Copy link
Member

Description

Supports streaming load mem chunk & Push down filter, limit and offset to MemPointIterator

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 64.52555% with 243 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.98%. Comparing base (72a11f3) to head (9cedd0f).
⚠️ Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
...gine/execution/operator/source/SeriesScanUtil.java 22.33% 80 Missing ⚠️
...engine/schemaregion/utils/ResourceByPathUtils.java 0.00% 66 Missing ⚠️
...rg/apache/iotdb/db/utils/datastructure/TVList.java 44.11% 57 Missing ⚠️
...he/iotdb/db/utils/datastructure/AlignedTVList.java 91.42% 6 Missing ⚠️
...structure/MergeSortMultiAlignedTVListIterator.java 73.91% 6 Missing ⚠️
...e/dataregion/memtable/AlignedReadOnlyMemChunk.java 91.52% 5 Missing ⚠️
...b/utils/datastructure/MemPointIteratorFactory.java 50.00% 4 Missing ⚠️
...tils/datastructure/MultiAlignedTVListIterator.java 93.10% 4 Missing ⚠️
...ine/execution/operator/source/FileLoaderUtils.java 0.00% 3 Missing ⚠️
...iotdb/db/utils/datastructure/MemPointIterator.java 86.95% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16246      +/-   ##
============================================
- Coverage     38.99%   38.98%   -0.01%     
  Complexity      198      198              
============================================
  Files          4886     4895       +9     
  Lines        319614   320997    +1383     
  Branches      40346    40670     +324     
============================================
+ Hits         124620   125140     +520     
- Misses       194994   195857     +863     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97 JackieTien97 requested a review from Copilot August 27, 2025 03:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements streaming memory chunk loading and pushes down filter, limit, and offset operations to MemPointIterator for improved query performance.

Key changes include:

  • Addition of streaming query capability for memory chunks to avoid loading excessive data
  • Implementation of filter, limit, and offset pushdown to MemPointIterator for more efficient data processing
  • Support for both ascending and descending scan orders in memory iteration

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
MemPointIterator.java Converted to abstract class with streaming support and pushdown capabilities
TVList.java Enhanced iterator with scan order support and filter/pagination pushdown
AlignedTVList.java Added streaming query support and scan order handling for aligned data
ReadOnlyMemChunk.java Added fake statistics generation for streaming queries
SeriesScanUtil.java Integrated lazy memory page readers for streaming chunk processing
IoTDBConfig.java Added configuration for streaming query memory chunks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JackieTien97 JackieTien97 merged commit 8e8c1a6 into master Aug 29, 2025
27 of 29 checks passed
@JackieTien97 JackieTien97 deleted the optimizeMemtableScan branch August 29, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments