Fix error of non-mappable udtf query in align by device while existing any devices' data cross region#16248
Merged
JackieTien97 merged 2 commits intomasterfrom Aug 26, 2025
Merged
Fix error of non-mappable udtf query in align by device while existing any devices' data cross region#16248JackieTien97 merged 2 commits intomasterfrom
JackieTien97 merged 2 commits intomasterfrom
Conversation
…g any devices' data cross region
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16248 +/- ##
=========================================
Coverage 38.99% 38.99%
Complexity 198 198
=========================================
Files 4886 4886
Lines 319575 319616 +41
Branches 40342 40348 +6
=========================================
+ Hits 124613 124630 +17
- Misses 194962 194986 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request updates the device view aggregation logic in the query engine to better handle User-Defined Table Functions (UDTFs) and clarifies when special processing is needed. The main changes involve extending the special-case handling to include UDTFs and refactoring related method names for clarity.
Device view aggregation logic improvements:
Analysis.javato clarify thatdeviceViewSpecialProcessapplies when all Aggregation Functions, UDTFs, and DIFF are present, not just Aggregation Functions and DIFF.SourceRewriter.javaso that special processing for device views is triggered when UDTFs are present, in addition to existing conditions. This is achieved by checking for the UDTF function type in the relevant method.FunctionTypeimport inSourceRewriter.javato support the new UDTF check.Code clarity and maintainability:
aggregationCannotUseMergeSort()tocannotUseAggMergeSort()inSourceRewriter.javafor improved readability and accuracy. [1] [2]