fix tests in ColumnInjectionPushDownTest#16564
Open
kabo87777 wants to merge 1 commit intoapache:masterfrom
Open
fix tests in ColumnInjectionPushDownTest#16564kabo87777 wants to merge 1 commit intoapache:masterfrom
kabo87777 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Non-Deterministic Behavior in ColumnInjectionPushDownTest
Problem
Two tests were failing non-deterministically under NonDex with ~50% failure rate:
testCannotPushDownTimeJoinAlignByTimetestPartialPushDownTimeJoinAlignByDeviceReproduce
cd iotdb-core/datanode mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex \ -Dtest=ColumnInjectionPushDownTest#testCannotPushDownTimeJoinAlignByTime \ -DnondexRuns=4Failure example:
java.lang.AssertionError: expected:ColumnInjectNode@79d58e5b but was:ColumnInjectNode@d7938b9b
Root Cause
Solution
Test utilities: Replaced
HashMapwithLinkedHashMapto preserve insertion orderOptimizationTestUtil.schemaMapOptimizationTestUtil.getAggregationDescriptor()deviceToMeasurementIndexesMapin testsProduction code: Implemented order-independent
equals()inFullOuterTimeJoinNodeKey Changed Classes
OptimizationTestUtil- HashMap → LinkedHashMapColumnInjectionPushDownTest- HashMap → LinkedHashMapTestPlanBuilder- HashMap → LinkedHashMapFullOuterTimeJoinNode- Order-independent equals()This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR