Delete the tsfile and related attachments When only one table and dat…#16687
Merged
jt2594838 merged 18 commits intoapache:masterfrom Nov 10, 2025
Merged
Delete the tsfile and related attachments When only one table and dat…#16687jt2594838 merged 18 commits intoapache:masterfrom
jt2594838 merged 18 commits intoapache:masterfrom
Conversation
…a is cleared fully in the tsfile
jt2594838
requested changes
Nov 3, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
…tree model to delete files related to tsfile.
…le are deleted after delete all data in a table.
…s exists first before scan the directory.
jt2594838
requested changes
Nov 5, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
jt2594838
requested changes
Nov 5, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
…er devices are all in the same one tsfile.
jt2594838
requested changes
Nov 6, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Show resolved
Hide resolved
jt2594838
approved these changes
Nov 6, 2025
…ed files are deleted by different time range if it's success.
HTHou
reviewed
Nov 7, 2025
HTHou
reviewed
Nov 10, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
JackieTien97
pushed a commit
that referenced
this pull request
Nov 26, 2025
#16687) * Delete the tsfile and related attachments When only one table and data is cleared fully in the tsfile * Adjust logic is only effective in the table model, and refers to the tree model to delete files related to tsfile. * Supply an IT test to validate if involved supporting files about tsfile are deleted after delete all data in a table. * Resolve problem reported that file is not exist in the situation of 1C3D. * File may be not exist in the situation of 1C3D so that verify if it is exists first before scan the directory. * Fix the logic that verify only on table When multiple devices in same one table. * Don't delete file until all devices matched by time. * Avoid to delete the file when the device that need be deleted and other devices are all in the same one tsfile. * Increment a break to avoid extra I/O in the same file. * After delete all datas from a table, validate multiple devices involved files are deleted by different time range if it's success. * Add some logs and trace cause. * Debug * Change into logger * Decrement interval time * Clean environment before run testCompletelyDeleteTable * Recover all workflow yml files, log level need change into "debug" level. * Add a verification due to performance considerations. * Add some verification due to performance considerations. (cherry picked from commit f675264)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the tsfile and related attachments When only one table and data is cleared fully in the tsfile. Avoid to create a same table and insert data slower after delete a table.