Skip to content

Conversation

@OneSizeFitsQuorum
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented Jan 7, 2026

Description

Backports improvements to the weekly CVE scanning workflow that were validated through Apache Ratis PR community review process.

Workflow Simplification

  • Removed matrix strategy: Single runner (ubuntu-latest, JDK 17) instead of matrix configuration
  • Removed Maven cache: Cache ineffective for weekly scheduled jobs
  • Consolidated dependency checks: aggregate step subsumes check step

Enhanced Configuration

  • Added conditional execution: Prevents forks from running scheduled scans (github.repository == 'apache/iotdb')
  • Added NVD API key support: -DnvdApiKey=${{ secrets.NVD_API_KEY }} parameter for improved CVE data access
  • Consistent Maven args: $MAVEN_ARGS variable usage across commands

Improved Clarity

  • Renamed DATE_EAST_ASIAREPORT_DATE: Clearer semantic meaning
  • Simplified artifact naming: Removed redundant ${{ runner.os }} component
  • Updated step descriptions: More precise naming

Security Hardening

  • Added explicit permissions: contents: read follows principle of least privilege

This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.

Copilot AI and others added 3 commits January 7, 2026 12:45
…orkflow

Co-authored-by: OneSizeFitsQuorum <32640567+OneSizeFitsQuorum@users.noreply.github.com>
Co-authored-by: OneSizeFitsQuorum <32640567+OneSizeFitsQuorum@users.noreply.github.com>
Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HTHou HTHou merged commit d19455d into apache:master Jan 8, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants