Pipe: preserve exclusions for complex wildcards #17170
Merged
+104
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
reviewed
Feb 5, 2026
Comment on lines
893
to
897
| if (containsComplexWildcard(path)) { | ||
| complexPatterns.add(path); | ||
| return; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Could you place the judge in the loop below? Otherwise, a path without complex wildcard will be traversed twice.
jt2594838
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve exclusion pruning when inclusion uses complex wildcards by falling back to PartialPath overlap/include checks in PatternTrie.
Add regression coverage for inclusion/exclusion pruning in unit and integration tests.
This PR was primarily authored with Codex using gpt-5.2-codex high and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.