Fix incorrect early termination in descending scan of unpackOneFakeMemChunkMetaData#17283
Open
Fix incorrect early termination in descending scan of unpackOneFakeMemChunkMetaData#17283
Conversation
59da8ef to
b8dad72
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17283 +/- ##
============================================
- Coverage 39.71% 39.70% -0.01%
Complexity 282 282
============================================
Files 5100 5100
Lines 341950 341977 +27
Branches 43559 43562 +3
============================================
- Hits 135798 135796 -2
- Misses 206152 206181 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Problem
In the streaming query path of MemChunkLoader, unpackOneFakeMemChunkMetaData iterates through statisticsList to construct LazyMemVersionPageReader instances.
However, the original implementation always iterated statisticsList in ascending order while using the following early termination logic:
When executing a descending scan, statisticsList is still ordered from small to large timestamps. This may cause the loop to break prematurely because the first element already satisfies orderTime < satisfiedTimeRange.getMin(), even though later elements could still fall within the query time range.
As a result, some valid pages may not be added to the page reader list, leading to missing data during descending scans.
Solution
This PR fixes the issue by iterating statisticsList according to the scan order:
• Ascending scan: iterate statisticsList in its natural order.
• Descending scan: iterate statisticsList in reverse order.
With this change, the early termination condition (break) becomes correct for both scan directions because the iteration order now matches the scan order.
The behavior is now consistent with the logic used in unpackOneChunkMetaData, where pageReaderList is also traversed differently depending on the scan order.