Skip to content

Support aggregation push-down optimize for table view of non aligned series #17294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wei-hao-Li wants to merge 14 commits into
base: master
Choose a base branch
from

fix the last(time) case

34dcbbd
Select commit
Loading
Failed to load commit list.
Open

Support aggregation push-down optimize for table view of non aligned series #17294

fix the last(time) case
34dcbbd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 18, 2026 in 3m 3s

Quality Gate passed

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.1% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 1249 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ5&open=AZziqPEpRDGblgXWVoZ5&pullRequest=17294

Check failure on line 197 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/AbstractAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCdguHjumTnDTP-&open=AZzkgUCdguHjumTnDTP-&pullRequest=17294

Check failure on line 94 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "clone" implementation; use a copy constructor or copy factory instead. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPDyRDGblgXWVoZ3&open=AZziqPDyRDGblgXWVoZ3&pullRequest=17294

Check warning on line 41 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 6 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQB&open=AZzkgUCmguHjumTnDTQB&pullRequest=17294

Check warning on line 38 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 7 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZx&open=AZziqOxIRDGblgXWVoZx&pullRequest=17294

Check warning on line 38 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 7 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPDyRDGblgXWVoZ1&open=AZziqPDyRDGblgXWVoZ1&pullRequest=17294

Check warning on line 119 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZz2UjYdEi8P_DWfWy42&open=AZz2UjYdEi8P_DWfWy42&pullRequest=17294

Check warning on line 94 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use super.clone() to create and seed the cloned instance to be returned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZy&open=AZziqOxIRDGblgXWVoZy&pullRequest=17294

Check warning on line 118 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'Exception'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQF&open=AZzkgUCmguHjumTnDTQF&pullRequest=17294

Check warning on line 119 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZz2UjGGEi8P_DWfWy41&open=AZz2UjGGEi8P_DWfWy41&pullRequest=17294

Check warning on line 60 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'treeDBName' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPDyRDGblgXWVoZ4&open=AZziqPDyRDGblgXWVoZ4&pullRequest=17294

Check warning on line 2952 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 179 to 64, Complexity from 21 to 14, Nesting Level from 4 to 2, Number of Variables from 40 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgTyLguHjumTnDTP6&open=AZzkgTyLguHjumTnDTP6&pullRequest=17294

Check warning on line 592 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'INSTANCE_SIZE' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZz56xeeACzsL9rD-ATy&open=AZz56xeeACzsL9rD-ATy&pullRequest=17294

Check warning on line 160 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

First sentence of Javadoc is missing an ending period. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQG&open=AZzkgUCmguHjumTnDTQG&pullRequest=17294

Check warning on line 178 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/LastQueryAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 136 to 64, Complexity from 18 to 14, Nesting Level from 4 to 2, Number of Variables from 14 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUC_guHjumTnDTQI&open=AZzkgUC_guHjumTnDTQI&pullRequest=17294

Check warning on line 873 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 121 to 64, Complexity from 20 to 14, Nesting Level from 3 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ7&open=AZziqPEpRDGblgXWVoZ7&pullRequest=17294

Check warning on line 592 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "INSTANCE_SIZE" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZz56xeeACzsL9rD-ATw&open=AZz56xeeACzsL9rD-ATw&pullRequest=17294

Check warning on line 1286 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'needSplit' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ-&open=AZziqPEpRDGblgXWVoZ-&pullRequest=17294

Check failure on line 94 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "clone" implementation; use a copy constructor or copy factory instead. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZz&open=AZziqOxIRDGblgXWVoZz&pullRequest=17294

Check warning on line 2851 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 101). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZz56xeeACzsL9rD-AT0&open=AZz56xeeACzsL9rD-AT0&pullRequest=17294

Check warning on line 4160 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 120 to 64, Complexity from 15 to 14, Nesting Level from 4 to 2, Number of Variables from 41 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgTyLguHjumTnDTP7&open=AZzkgTyLguHjumTnDTP7&pullRequest=17294

Check warning on line 310 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 65 to 64, Complexity from 15 to 14, Nesting Level from 5 to 2, Number of Variables from 16 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ6&open=AZziqPEpRDGblgXWVoZ6&pullRequest=17294

Check warning on line 733 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/AbstractAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCdguHjumTnDTP_&open=AZzkgUCdguHjumTnDTP_&pullRequest=17294

Check warning on line 1249 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 161 to 64, Complexity from 21 to 14, Nesting Level from 3 to 2, Number of Variables from 26 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ8&open=AZziqPEpRDGblgXWVoZ8&pullRequest=17294

Check warning on line 60 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'treeDBName' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZ0&open=AZziqOxIRDGblgXWVoZ0&pullRequest=17294
View more details on SonarQubeCloud