Skip to content

Improve OpenID auth #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HTHou wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Improve OpenID auth #17302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0d754c9
Reject expired OpenID tokens and add regression test
HTHou Mar 17, 2026
df788e0
Validate OpenID issuer and audience claims
HTHou Mar 17, 2026
8d826b4
Replace JJWT test token generation with Nimbus JWT
HTHou Mar 17, 2026
7231e1c
Restore JWT test runtime dependencies
HTHou Mar 17, 2026
e3f43ad
fix ut
HTHou Mar 17, 2026
c1bc077
spotless
HTHou Mar 17, 2026
531a7c9
Add test-scoped Nimbus JWT dependency for datanode tests
HTHou Mar 17, 2026
9e09e7b
Move authorizer tests to node-commons
HTHou Mar 17, 2026
36db628
Remove unused JJWT test dependencies from datanode
HTHou Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions iotdb-core/datanode/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,33 +277,11 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
<!-- Possibly these need to move into the compile or provided scope -->
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-impl</artifactId>
<scope>test</scope>
</dependency>
<!-- Possibly these need to move into the compile or provided scope -->
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-jackson</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>net.minidev</groupId>
<artifactId>json-smart</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.ratis</groupId>
<artifactId>ratis-thirdparty-misc</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.nimbusds</groupId>
<artifactId>oauth2-oidc-sdk</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-core</artifactId>
Expand Down Expand Up @@ -488,11 +466,6 @@
<!-- For some reason this plugin missed it being used for a constant import -->
<ignoredDependency>org.apache.iotdb:isession</ignoredDependency>
</ignoredDependencies>
<usedDependencies>
<!-- These are used at runtime in tests -->
<usedDependency>io.jsonwebtoken:jjwt-impl</usedDependency>
<usedDependency>io.jsonwebtoken:jjwt-jackson</usedDependency>
</usedDependencies>
</configuration>
</plugin>
<plugin>
Expand Down
114 changes: 0 additions & 114 deletions ...core/datanode/src/test/java/org/apache/iotdb/db/auth/authorizer/OpenIdAuthorizerTest.java
View file
Open in desktop

This file was deleted.

20 changes: 20 additions & 0 deletions iotdb-core/node-commons/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,16 @@
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-api</artifactId>
</dependency>
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-impl</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-jackson</artifactId>
<scope>test</scope>
Comment on lines +155 to +160
Comment on lines +155 to +160
</dependency>
<dependency>
<groupId>com.nimbusds</groupId>
<artifactId>oauth2-oidc-sdk</artifactId>
Expand Down Expand Up @@ -267,6 +277,16 @@
</plugin>
<!--using `mvn test` to run UT, `mvn verify` to run ITs
Reference: https://antoniogoncalves.org/2012/12/13/lets-turn-integration-tests-with-maven-to-a-first-class-citizen/-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>io.jsonwebtoken:jjwt-impl</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>io.jsonwebtoken:jjwt-jackson</ignoredUnusedDeclaredDependency>
</ignoredUnusedDeclaredDependencies>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1753,6 +1753,12 @@ authorizer_provider_class=org.apache.iotdb.commons.auth.authorizer.LocalFileAuth
# Privilege: SECURITY
openID_url=

# If OpenIdAuthorizer is enabled, then openID_audience must contain the IoTDB client ID
# or a comma-separated allowlist of accepted audiences.
# effectiveMode: restart
# Privilege: SECURITY
openID_audience=

# encryption provider class
# effectiveMode: first_start
iotdb_server_encrypt_decrypt_provider=org.apache.iotdb.commons.security.encrypt.MessageDigestEncrypt
Expand Down
Loading
Loading