Clean up tmp dirs of udf and sort while starting up#17377
Merged
JackieTien97 merged 3 commits intomasterfrom Mar 27, 2026
Merged
Clean up tmp dirs of udf and sort while starting up#17377JackieTien97 merged 3 commits intomasterfrom
JackieTien97 merged 3 commits intomasterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17377 +/- ##
============================================
- Coverage 39.78% 39.78% -0.01%
Complexity 312 312
============================================
Files 5127 5127
Lines 346311 346324 +13
Branches 44105 44106 +1
============================================
- Hits 137785 137774 -11
- Misses 208526 208550 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackieTien97
added a commit
that referenced
this pull request
Mar 27, 2026
(cherry picked from commit 32f1010)
JackieTien97
added a commit
that referenced
this pull request
Mar 28, 2026
) (cherry picked from commit 32f1010)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces improvements to resource cleanup and thread safety in the DataNode service, focusing on temporary directories and query data file management. The main changes ensure that stale temporary files and directories are properly cleaned up during startup and shutdown, and that access to shared data structures is thread-safe.
Resource cleanup improvements:
cleanupSortTmpDirmethod and invoking it in thesetUpprocess. [1] [2]TemporaryQueryDataFileService, stale temporary directories are now deleted at startup and shutdown to prevent accumulation of unused files. [1] [2]Thread safety enhancements:
SerializationRecorderobjects to use a synchronized list, ensuring thread-safe access to therecordersmap.Minor code cleanup:
ExecutableManager. [1] [2]CollectionsinTemporaryQueryDataFileService.