Skip to content

Fix blocking Windows metric binding during startup#17423

Merged
jt2594838 merged 1 commit intomasterfrom
opt/windows_metric_bind
Apr 2, 2026
Merged

Fix blocking Windows metric binding during startup#17423
jt2594838 merged 1 commit intomasterfrom
opt/windows_metric_bind

Conversation

@HTHou
Copy link
Copy Markdown
Contributor

@HTHou HTHou commented Apr 2, 2026

Summary

  • bind Windows disk and net metric registration on background daemon threads instead of blocking bindTo
  • remove eager Windows metric collection during manager construction so startup does not trigger synchronous metric fetches
  • drop fixed 5-second waits from session integration tests that are no longer needed after metric binding becomes asynchronous

Testing

  • Not run (not requested)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
95.7% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.75%. Comparing base (75bfa23) to head (fedff2b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...che/iotdb/metrics/metricsets/disk/DiskMetrics.java 0.00% 8 Missing ⚠️
...pache/iotdb/metrics/metricsets/net/NetMetrics.java 0.00% 8 Missing ⚠️
...etrics/metricsets/net/WindowsNetMetricManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17423   +/-   ##
=========================================
  Coverage     39.75%   39.75%           
  Complexity      312      312           
=========================================
  Files          5134     5134           
  Lines        346900   346907    +7     
  Branches      44193    44194    +1     
=========================================
+ Hits         137899   137905    +6     
- Misses       209001   209002    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 55082b2 into master Apr 2, 2026
29 of 30 checks passed
@jt2594838 jt2594838 deleted the opt/windows_metric_bind branch April 2, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants