Fix duplicate deletion emission in TsFileSplitter#17534
Merged
jt2594838 merged 2 commits intoapache:masterfrom Apr 22, 2026
Merged
Fix duplicate deletion emission in TsFileSplitter#17534jt2594838 merged 2 commits intoapache:masterfrom
jt2594838 merged 2 commits intoapache:masterfrom
Conversation
Avoid applying deletions while switching time chunk context, which could emit the same deletion entries multiple times for aligned multi-device files. Add a regression test that verifies emitted deletion mods match expected mods exactly. Made-with: Cursor
jt2594838
approved these changes
Apr 21, 2026
Caideyipi
pushed a commit
to Caideyipi/iotdb
that referenced
this pull request
Apr 27, 2026
* Fix duplicate deletion emission in TsFileSplitter Avoid applying deletions while switching time chunk context, which could emit the same deletion entries multiple times for aligned multi-device files. Add a regression test that verifies emitted deletion mods match expected mods exactly. Made-with: Cursor * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid applying deletions while switching time chunk context, which could emit the same deletion entries multiple times for aligned multi-device files. Add a regression test that verifies emitted deletion mods match expected mods exactly.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR