Use MemoizedCheckedSupplier for COPY TO folder manager & keep compatibility with another branch#17559
Merged
JackieTien97 merged 2 commits intomasterfrom Apr 27, 2026
Merged
Use MemoizedCheckedSupplier for COPY TO folder manager & keep compatibility with another branch#17559JackieTien97 merged 2 commits intomasterfrom
JackieTien97 merged 2 commits intomasterfrom
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17559 +/- ##
============================================
- Coverage 39.85% 39.85% -0.01%
Complexity 2547 2547
============================================
Files 5171 5171
Lines 348174 348176 +2
Branches 44489 44489
============================================
Hits 138767 138767
- Misses 209407 209409 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackieTien97
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR updates
TierManagerto lazily initialize the COPY TO targetFolderManagerwithMemoizedCheckedSupplier, so COPY TO target directories are not created during startup or tier initialization when the COPY TO feature is not used.It also keeps several query execution context and DataNode service visibility changes for compatibility with another branch, including passing an optional memory reservation manager through column transformer context construction.
Key Changes
TierManagerto useMemoizedCheckedSupplier.MemoryReservationManagerplumbing to column transformer contexts.templates/**from datanode codegen resources.DataNodeInternalRPCService.implanddataNodeContextaccessible to subclasses.