Skip to content

Use MemoizedCheckedSupplier for COPY TO folder manager & keep compatibility with another branch#17559

Merged
JackieTien97 merged 2 commits intomasterfrom
fix_0427
Apr 27, 2026
Merged

Use MemoizedCheckedSupplier for COPY TO folder manager & keep compatibility with another branch#17559
JackieTien97 merged 2 commits intomasterfrom
fix_0427

Conversation

@shuwenwei
Copy link
Copy Markdown
Member

@shuwenwei shuwenwei commented Apr 27, 2026

Description

This PR updates TierManager to lazily initialize the COPY TO target FolderManager with MemoizedCheckedSupplier, so COPY TO target directories are not created during startup or tier initialization when the COPY TO feature is not used.

It also keeps several query execution context and DataNode service visibility changes for compatibility with another branch, including passing an optional memory reservation manager through column transformer context construction.

Key Changes

  • Changed COPY TO target folder manager initialization in TierManager to use MemoizedCheckedSupplier.
  • Avoided creating COPY TO target directories unless the COPY TO target folder is actually requested.
  • Kept compatibility changes for another branch by adding optional MemoryReservationManager plumbing to column transformer contexts.
  • Excluded templates/** from datanode codegen resources.
  • Made DataNodeInternalRPCService.impl and dataNodeContext accessible to subclasses.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.85%. Comparing base (ce84224) to head (6783932).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...otdb/db/storageengine/rescon/disk/TierManager.java 50.00% 2 Missing ⚠️
...e/plan/planner/DataNodeTableOperatorGenerator.java 0.00% 1 Missing ⚠️
...e/iotdb/db/service/DataNodeInternalRPCService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17559      +/-   ##
============================================
- Coverage     39.85%   39.85%   -0.01%     
  Complexity     2547     2547              
============================================
  Files          5171     5171              
  Lines        348174   348176       +2     
  Branches      44489    44489              
============================================
  Hits         138767   138767              
- Misses       209407   209409       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97 JackieTien97 merged commit cf718f6 into master Apr 27, 2026
29 of 30 checks passed
@JackieTien97 JackieTien97 deleted the fix_0427 branch April 27, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants