Skip to content

[To dev/1.3] Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close (#17549)#17569

Merged
jt2594838 merged 3 commits intodev/1.3from
fix-13-disruptor
Apr 30, 2026
Merged

[To dev/1.3] Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close (#17549)#17569
jt2594838 merged 3 commits intodev/1.3from
fix-13-disruptor

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 78.30882% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.61%. Comparing base (e96ce95) to head (c15c096).
⚠️ Report is 12 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...region/realtime/disruptor/BatchEventProcessor.java 76.27% 14 Missing ⚠️
...ion/realtime/disruptor/MultiProducerSequencer.java 79.68% 13 Missing ⚠️
...urce/dataregion/realtime/disruptor/RingBuffer.java 76.92% 9 Missing ⚠️
...ource/dataregion/realtime/disruptor/Disruptor.java 80.48% 8 Missing ⚠️
...source/dataregion/realtime/disruptor/Sequence.java 68.18% 7 Missing ⚠️
...dataregion/realtime/disruptor/SequenceBarrier.java 62.50% 6 Missing ⚠️
.../dataregion/realtime/disruptor/SequenceGroups.java 93.75% 1 Missing ⚠️
...altime/listener/PipeInsertionDataNodeListener.java 93.33% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17569      +/-   ##
=============================================
+ Coverage      41.58%   41.61%   +0.03%     
  Complexity       227      227              
=============================================
  Files           3597     3604       +7     
  Lines         237111   237373     +262     
  Branches       28694    28729      +35     
=============================================
+ Hits           98605    98793     +188     
- Misses        138506   138580      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 250d97a into dev/1.3 Apr 30, 2026
23 of 25 checks passed
@jt2594838 jt2594838 deleted the fix-13-disruptor branch April 30, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants