Skip to content

[To dev/1.3] Pipe: Fixed the event clear logic of drop pipe (#17560)#17619

Merged
jt2594838 merged 4 commits intodev/1.3from
drop-fix
May 9, 2026
Merged

[To dev/1.3] Pipe: Fixed the event clear logic of drop pipe (#17560)#17619
jt2594838 merged 4 commits intodev/1.3from
drop-fix

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Caideyipi added 4 commits May 8, 2026 17:07
* drop-1

* wd

* drop

* fix

* local

* triple

* by

* spt

* bug-fix

* no-pipe-task-key

* Update IoTDBDataRegionAsyncSink.java

* triple

* Fix
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 65.83851% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.98%. Comparing base (77e9403) to head (de61ca8).
⚠️ Report is 2 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...k/protocol/websocket/WebSocketConnectorServer.java 65.67% 23 Missing ⚠️
...pe/agent/task/connection/BlockingPendingQueue.java 69.56% 7 Missing ⚠️
...rotocol/thrift/async/IoTDBDataRegionAsyncSink.java 70.00% 6 Missing ⚠️
...db/pipe/sink/protocol/websocket/WebSocketSink.java 0.00% 4 Missing ⚠️
...pache/iotdb/commons/pipe/datastructure/Triple.java 73.33% 4 Missing ⚠️
.../payload/evolvable/batch/PipeTabletEventBatch.java 0.00% 3 Missing ⚠️
...ubtask/sink/PipeRealtimePriorityBlockingQueue.java 50.00% 2 Missing ⚠️
.../pipe/agent/task/subtask/sink/PipeSinkSubtask.java 66.66% 2 Missing ⚠️
...nt/task/subtask/sink/PipeSinkSubtaskLifeCycle.java 0.00% 1 Missing ⚠️
...gent/task/subtask/sink/PipeSinkSubtaskManager.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17619      +/-   ##
=============================================
+ Coverage      41.76%   41.98%   +0.21%     
  Complexity       241      241              
=============================================
  Files           3611     3612       +1     
  Lines         238173   238282     +109     
  Branches       28928    28953      +25     
=============================================
+ Hits           99465   100034     +569     
+ Misses        138708   138248     -460     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 2ea083d into dev/1.3 May 9, 2026
18 of 20 checks passed
@jt2594838 jt2594838 deleted the drop-fix branch May 9, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants