Skip to content

[To dev/1.3] Fix that WALBuffer waits for flush instead of file-roll (#17628) #17633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 2 commits into from
May 12, 2026

fix test compilation

3bed9a1
Select commit
Loading
Failed to load commit list.
Merged

[To dev/1.3] Fix that WALBuffer waits for flush instead of file-roll (#17628) #17633

fix test compilation
3bed9a1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 11, 2026 in 1m 56s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 676 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to "await" or move it into a "while" loop. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMEcwyfbI-4Ocn5h&open=AZ4VqMEcwyfbI-4Ocn5h&pullRequest=17633

Check failure on line 665 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to "await" or move it into a "while" loop. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMEcwyfbI-4Ocn5g&open=AZ4VqMEcwyfbI-4Ocn5g&pullRequest=17633

Check warning on line 170 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'file' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMEcwyfbI-4Ocn5i&open=AZ4VqMEcwyfbI-4Ocn5i&pullRequest=17633

Check warning on line 270 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5b&open=AZ4VqMDqwyfbI-4Ocn5b&pullRequest=17633

Check failure on line 65 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5W&open=AZ4VqMDqwyfbI-4Ocn5W&pullRequest=17633

Check failure on line 64 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5V&open=AZ4VqMDqwyfbI-4Ocn5V&pullRequest=17633

Check failure on line 68 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5Y&open=AZ4VqMDqwyfbI-4Ocn5Y&pullRequest=17633

Check warning on line 199 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'waitFuture' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5f&open=AZ4VqMDqwyfbI-4Ocn5f&pullRequest=17633

Check failure on line 67 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5X&open=AZ4VqMDqwyfbI-4Ocn5X&pullRequest=17633

Check failure on line 69 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5Z&open=AZ4VqMDqwyfbI-4Ocn5Z&pullRequest=17633

Check warning on line 19 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'package' should be separated from previous line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5c&open=AZ4VqMDqwyfbI-4Ocn5c&pullRequest=17633

Check warning on line 598 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 96 to 64, Complexity from 20 to 14, Nesting Level from 6 to 2, Number of Variables from 9 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMFEwyfbI-4Ocn5j&open=AZ4VqMFEwyfbI-4Ocn5j&pullRequest=17633

Check warning on line 213 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5a&open=AZ4VqMDqwyfbI-4Ocn5a&pullRequest=17633

Check warning on line 73 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'originWALThreshold' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5e&open=AZ4VqMDqwyfbI-4Ocn5e&pullRequest=17633

Check warning on line 62 in iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeWaitForRollFileTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'WALNodeWaitForRollFileTest' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4VqMDqwyfbI-4Ocn5d&open=AZ4VqMDqwyfbI-4Ocn5d&pullRequest=17633
View more details on SonarQubeCloud