Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17703 +/- ##
============================================
+ Coverage 40.26% 40.61% +0.35%
Complexity 2574 2574
============================================
Files 5179 5179
Lines 349659 350388 +729
Branches 44688 44820 +132
============================================
+ Hits 140798 142324 +1526
+ Misses 208861 208064 -797 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Excludes audit/system from COUNT TIMESERIES and includes views in counts. Core behavior is covered by new tests, but the main integration test for exclude-internal-and-include-view is @ignore, so CI does not verify the feature.
Please remove @ignore and make the test pass before merge.
| } | ||
|
|
||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
Blocking: showCountTimeSeriesExcludeInternalDatabaseAndIncludeView is ignored, so CI will not run assertions for audit/system exclusion, view inclusion, or root.** totals. Fix the underlying flake or failure and remove @ignore before merging.
There was a problem hiding this comment.
View is not included in this version and cannot be tested here



Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR