Conversation
|
HTHou
approved these changes
May 22, 2026
luoluoyuyu
approved these changes
May 27, 2026
Member
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Improves Windows disk metrics collection: resolves powershell.exe under System32, backs off for 5 minutes after failures, rate-limits failure logs, and injects PowerShellExecutor for testing.
Looks good to merge.
| List<String> result = new ArrayList<>(); | ||
| List<String> rawOutput = new ArrayList<>(); | ||
| Process process = null; | ||
| if (System.currentTimeMillis() < nextPowerShellRetryTime) { |
Member
There was a problem hiding this comment.
During backoff, returning an empty list means disk metrics are temporarily absent rather than stale. Acceptable to stop log storms; optional improvement is to log next retry time at WARN when entering backoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR