[IOTDB-1131]Improve wal by using differential logging#1869
Closed
[IOTDB-1131]Improve wal by using differential logging#1869
Conversation
# Conflicts: # server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java # server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java # server/src/main/java/org/apache/iotdb/db/qp/physical/PhysicalPlan.java # server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertTabletPlan.java # server/src/main/java/org/apache/iotdb/db/utils/CommonUtils.java # server/src/main/java/org/apache/iotdb/db/writelog/recover/TsFileRecoverPerformer.java
fix log selection in log window
# Conflicts: # server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java # server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java # server/src/main/java/org/apache/iotdb/db/qp/physical/PhysicalPlan.java # server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertTabletPlan.java # server/src/main/java/org/apache/iotdb/db/utils/CommonUtils.java # server/src/main/java/org/apache/iotdb/db/utils/SerializeUtils.java # server/src/main/java/org/apache/iotdb/db/writelog/node/ExclusiveWriteLogNode.java
SilverNarcissus
requested changes
Dec 14, 2020
Contributor
SilverNarcissus
left a comment
SilverNarcissus
left a comment
There was a problem hiding this comment.
Nice work and detailed design with analyze. Only have some small issues, please have a look~
server/src/main/java/org/apache/iotdb/db/writelog/recover/LogReplayer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/writelog/io/ILogReaderFactory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/utils/datastructure/RandomAccessArrayDeque.java
Show resolved
Hide resolved
# Conflicts: # server/src/main/java/org/apache/iotdb/db/qp/physical/PhysicalPlan.java # server/src/main/java/org/apache/iotdb/db/writelog/node/ExclusiveWriteLogNode.java
|
Kudos, SonarCloud Quality Gate passed!
|
SilverNarcissus
approved these changes
Dec 17, 2020
Contributor
SilverNarcissus
left a comment
SilverNarcissus
left a comment
There was a problem hiding this comment.
Look good to me~
jixuan1989
changed the title
Member
|
ping. |
Contributor
|
The conflicts fixed. The PR looks better now! |
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WALs may contain duplicated fields like deviceIds, measurementsId and data types. This PR aims to eliminate them to improve WAL performance when using small batchSize and without damaging the performance when using large batchSize.
Design:
Differential Logging.docx
Evaluation:
differentiation_logging.xlsx