-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[IOTDB-1597] Finish DIFF encoding algorithm which is reserved in enum before #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DiffEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
tsfile/src/test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DiffEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DiffEncoder.java
Outdated
Show resolved
Hide resolved
docs/UserGuide/Operation Manual/DML Data Manipulation Language.md
Outdated
Show resolved
Hide resolved
|
please apply this patch to solve the conflicts. |
|
I have made some experiment abouot it(https://cwiki.apache.org/confluence/display/IOTDB/DIFF+encoding%27s+perfomance). I add it beacuse DIFF is a reserved method, it's one of the recommending method when user want to choose a encoding method in IoTDB, but it's not finished before. It's in the system prompt, but user can't chooose it |
|
Hi, please resolve the conflicts |
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/Decoder.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DeltaBinaryEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DeltaBinaryEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DeltaBinaryEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DeltaBinaryEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DeltaBinaryEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/tsfile/encoding/decoder/delta/DeltaBinaryEncoderIntegerTest.java
Outdated
Show resolved
Hide resolved
HTHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now.

In the enum class: TSEncoding, there's DIFF encoding, so when user want to choose a type of encoding algorithm(or input the wrong encoding type name), DIFF encoding is in the output hint and is one of IoTDB's recommending encoding type,
but in IoTDB, DIFF encoding has not been added before, which I think may cause some problems.
I think it's necessary to finish it.
Both DIFF and TS_2DIFF encoding are based on delta encoding algorithm,
so I finish DIFF using similar interfaces and structures like TS_2DIFF to make it easier to understand.