[IOTDB-968] Support time predicate in select last#1898
Merged
HTHou merged 6 commits intoapache:masterfrom Oct 30, 2020
Merged
Conversation
JackieTien97
requested changes
Oct 29, 2020
Comment on lines
+184
to
+187
| if (filter != null && | ||
| filter.satisfy(tvPair.getTimestamp(), tvPair.getValue().getValue())) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
if the filter is null, shoudn't we return true?
Comment on lines
+219
to
+221
| if (timeFilter == null) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Same as before, if the filter is null, shoudn't we return true?
JackieTien97
approved these changes
Oct 30, 2020
HTHou
approved these changes
Oct 30, 2020
5Reeson
pushed a commit
to 5Reeson/iotdb
that referenced
this pull request
Oct 30, 2020
* Support time filter for last query * Add last with filter test * Fix test issues * Refuse to accept value filter in FROM clause * Fix code bug * Update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/IOTDB-968