Skip to content

fix travis closing some ports failed #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jixuan1989 merged 7 commits into from
Nov 7, 2020
Merged

fix travis closing some ports failed #1967

jixuan1989 merged 7 commits into from
Nov 7, 2020

Conversation

@jixuan1989
Copy link
Member

@jixuan1989 jixuan1989 commented Nov 6, 2020

  1. Travis usually closes 5555 port failed, because of a bug in some tearDown() methods..
  2. This PR prolongs the wait time of closing checkTTLThread() from 30 seconds to 60 seconds
  3. Once Travis finds some ports are closed failed, the travis will fail directly.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@jixuan1989 jixuan1989 merged commit 6489630 into master Nov 7, 2020
@jixuan1989 jixuan1989 deleted the test_travis branch November 7, 2020 02:46
@jixuan1989
Copy link
Member Author

jixuan1989 commented Nov 7, 2020

merged into 0.11

jixuan1989 added a commit that referenced this pull request Nov 7, 2020
@jixuan1989
fix travis closing some ports failed (#1967)
5722eaf 
* add wait time for stoping StorageEngine
* open test whether the port is closed on travis
* fast failed if port is not closed
* fix bug that sync thread is not closed in UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jixuan1989