Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
HTHou
approved these changes
Nov 12, 2020
samperson1997
approved these changes
Nov 12, 2020
qiaojialin
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the previous query load the timeseries metadata into cache. And when it has finished for a while(the file reader has been removed from the file reader manager cache), current query use the same timeseries metadata, the cache hits. However, we have to reopne the file reader and use the reopened file reader and cached timeseries metadata to load the chunk metadata.
But the reopened reader has not init the tsfileMetadata.