Skip to content

[Distributed] fix session cache leader interface and docs#2183

Closed
OneSizeFitsQuorum wants to merge 4 commits intoapache:cluster_newfrom
OneSizeFitsQuorum:cluster_new_add_session_cache_leader_interface_and_docs
Closed

[Distributed] fix session cache leader interface and docs#2183
OneSizeFitsQuorum wants to merge 4 commits intoapache:cluster_newfrom
OneSizeFitsQuorum:cluster_new_add_session_cache_leader_interface_and_docs

Conversation

@OneSizeFitsQuorum
Copy link
Contributor

As cluster_new is closing to merge into master, It is better not to open the leader cache by default and give an parameter interface for distributed IoTDB, otherwise it will cause unnecessary performance waste to the stand-alone IoTDB.

Copy link
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum force-pushed the cluster_new_add_session_cache_leader_interface_and_docs branch from 0c23347 to 85f49a2 Compare December 4, 2020 06:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OneSizeFitsQuorum
Copy link
Contributor Author

OneSizeFitsQuorum commented Dec 9, 2020

As cluster_new has been merged into cluster using squash, this PR is not able to merge into master. So I will close this PR and create a new one based on master's latest commit.

@OneSizeFitsQuorum OneSizeFitsQuorum deleted the cluster_new_add_session_cache_leader_interface_and_docs branch December 9, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants