Skip to content

fix bug that when rpc compression = true, sync client does not use compression mode#2197

Merged
qiaojialin merged 1 commit intomasterfrom
fix_sync_rpc_comrepss_bug
Dec 7, 2020
Merged

fix bug that when rpc compression = true, sync client does not use compression mode#2197
qiaojialin merged 1 commit intomasterfrom
fix_sync_rpc_comrepss_bug

Conversation

@jixuan1989
Copy link
Member

When the thrift server is initialized, the protocol is:

    if (compress) {
      protocolFactory = new TCompactProtocol.Factory();
    } else {
      protocolFactory = new TBinaryProtocol.Factory();
    }

So, the client must be the same.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@qiaojialin qiaojialin merged commit aea5a8d into master Dec 7, 2020
@qiaojialin qiaojialin deleted the fix_sync_rpc_comrepss_bug branch December 7, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants