Skip to content

[rel/0.11] fix bug that when rpc compression = true, sync client does not use compression mode#2198

Merged
jixuan1989 merged 2 commits intorel/0.11from
fix_sync_rpc_comrepss_bug_0.11
Dec 5, 2020
Merged

[rel/0.11] fix bug that when rpc compression = true, sync client does not use compression mode#2198
jixuan1989 merged 2 commits intorel/0.11from
fix_sync_rpc_comrepss_bug_0.11

Conversation

@jixuan1989
Copy link
Member

When the thrift server is initialized, the protocol is:

    if (compress) {
      protocolFactory = new TCompactProtocol.Factory();
    } else {
      protocolFactory = new TBinaryProtocol.Factory();
    }

So, the client must be the same.

Alima777 and others added 2 commits December 5, 2020 22:08
remove Serializable interface on BatchData
Co-authored-by: LebronAl <TXYPotato@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@jixuan1989 jixuan1989 merged commit aedfa20 into rel/0.11 Dec 5, 2020
@jixuan1989 jixuan1989 deleted the fix_sync_rpc_comrepss_bug_0.11 branch December 5, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants