Skip to content

[IOTDB-1068] Fix Time series metadata cache bug#2316

Merged
JackieTien97 merged 7 commits intomasterfrom
TimeSeriesMetadataCacheBugMaster
Jan 4, 2021
Merged

[IOTDB-1068] Fix Time series metadata cache bug#2316
JackieTien97 merged 7 commits intomasterfrom
TimeSeriesMetadataCacheBugMaster

Conversation

@JackieTien97
Copy link
Contributor

Currently, we add the entry size each time we put it into cache map. However, if the key already exists in cache, we will add the size again which will cause the cache used size is higher than the actual size.

Also, in this PR, I improve the process of deserializing time series metadata cache from disk.

@JackieTien97 JackieTien97 added the bug Something isn't working label Dec 23, 2020
Copy link
Member

@qiaojialin qiaojialin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 3 Code Smells

No Coverage information No Coverage information
12.3% 12.3% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@rhmangmang
Copy link
Contributor

Currently, we add the entry size each time we put it into cache map. However, if the key already exists in cache, we will add the size again which will cause the cache used size is higher than the actual size.

Also, in this PR, I improve the process of deserializing time series metadata cache from disk.

Hi, a PR should mainly contain one changing intention. It's better to open another PR to improve the process of deserializing time series metadata cache from disk.

@JackieTien97 JackieTien97 merged commit 85d4a00 into master Jan 4, 2021
@qiaojialin qiaojialin deleted the TimeSeriesMetadataCacheBugMaster branch June 16, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants