[Distributed] Fix init serialToParallelPool bug if cpu.cores > 100

[OneSizeFitsQuorum]

We will encounter a exception when starting cluster server if cpu.cores > 100, so we should change the parameters for ThreadPoolExecutor. As serialToParallelPool will only do heartbeat or add/remove node, I think the coreSize can be 'allNode.size()', and the maxSize can be set to Math.max(allNodes.size(), Runtime.getRuntime().availableProcessors()).

[neuyilan]

Good Job! besides, envy that you have more than 100 cores servers~
But what about the server's CPUs less than the allNodes.size()?

I think we can reference the code when creating RaftServer[1]

int maxConcurrentClientNum = Math.max(CommonUtils.getCpuCores(), config.getMaxConcurrentClientNum()); TThreadPoolServer.Args poolArgs = new TThreadPoolServer.Args(socket).maxWorkerThreads(maxConcurrentClientNum) .minWorkerThreads(CommonUtils.getCpuCores());
[1]
https://github.com/apache/iotdb/blob/master/cluster/src/main/java/org/apache/iotdb/cluster/utils/ClusterUtils.java#L242

[OneSizeFitsQuorum]

Good Job! besides, envy that you have more than 100 cores servers~

Scale up is too nice, I've forgotten how to scale out~

[OneSizeFitsQuorum]

int maxConcurrentClientNum = Math.max(CommonUtils.getCpuCores(), config.getMaxConcurrentClientNum());

You are right.But I think the core size can be smaller than cpu.core. What about this？ serialToParallelPool = new ThreadPoolExecutor(allNodes.size(), Math.max(allNodes.size(), Runtime.getRuntime().availableProcessors()), 1000L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>(), new ThreadFactoryBuilder().setNameFormat(getName() + "-SerialToParallel%d").build());

[neuyilan]

int maxConcurrentClientNum = Math.max(CommonUtils.getCpuCores(), config.getMaxConcurrentClientNum());

You are right.But I think the core size can be smaller than cpu.core. What about this？ serialToParallelPool = new ThreadPoolExecutor(allNodes.size(), Math.max(allNodes.size(), Runtime.getRuntime().availableProcessors()), 1000L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>(), new ThreadFactoryBuilder().setNameFormat(getName() + "-SerialToParallel%d").build());

LGTM

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication