Skip to content

[To rel/0.11] print more insert error message in client #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samperson1997 merged 2 commits into from
Dec 30, 2020
Merged

[To rel/0.11] print more insert error message in client #2381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07ac0c
print more insert error in client
HTHou Dec 30, 2020
69ea4af
fix bug
HTHou Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,21 +889,24 @@ public void insert(InsertRowPlan insertRowPlan) throws QueryProcessException {
List<String> failedPaths = insertRowPlan.getFailedMeasurements();
List<Exception> exceptions = insertRowPlan.getFailedExceptions();
boolean isPathNotExistException = true;
Exception exception = null;
for (Exception e : exceptions) {
Throwable curException = e;
while (curException.getCause() != null) {
curException = curException.getCause();
}
if (!(curException instanceof PathNotExistException)) {
isPathNotExistException = false;
exception = e;
break;
}
}
if (isPathNotExistException) {
throw new PathNotExistException(failedPaths);
} else {
throw new StorageEngineException(
"failed to insert points " + insertRowPlan.getFailedMeasurements());
"failed to insert points " + insertRowPlan.getFailedMeasurements() +
": " + exception.getMessage());
}
}
} catch (StorageEngineException | MetadataException e) {
Expand All @@ -926,6 +929,7 @@ public void insert(InsertRowsOfOneDevicePlan insertRowsOfOneDevicePlan)

List<String> notExistedPaths = null;
List<String> failedMeasurements = null;
Exception exception = null;
for (InsertRowPlan plan : insertRowsOfOneDevicePlan.getRowPlans()) {
if (plan.getFailedMeasurements() != null) {
if (notExistedPaths == null) {
Expand All @@ -943,6 +947,7 @@ public void insert(InsertRowsOfOneDevicePlan insertRowsOfOneDevicePlan)
}
if (!(curException instanceof PathNotExistException)) {
isPathNotExistException = false;
exception = e;
break;
}
}
Expand All @@ -955,9 +960,10 @@ public void insert(InsertRowsOfOneDevicePlan insertRowsOfOneDevicePlan)
}
if (notExistedPaths != null && !notExistedPaths.isEmpty()) {
throw new PathNotExistException(notExistedPaths);
} else if (notExistedPaths != null && !failedMeasurements.isEmpty()) {
} else if (notExistedPaths != null && !failedMeasurements.isEmpty() && exception != null) {
throw new StorageEngineException(
"failed to insert points " + failedMeasurements);
"failed to insert points " + failedMeasurements +
": " + exception.getMessage());
}

} catch (StorageEngineException | MetadataException e) {
Expand Down