Skip to content

fix merge bug for #2404#2415

Merged
OneSizeFitsQuorum merged 1 commit intoapache:masterfrom
mychaow:fix_merge_bug_2404
Jan 4, 2021
Merged

fix merge bug for #2404#2415
OneSizeFitsQuorum merged 1 commit intoapache:masterfrom
mychaow:fix_merge_bug_2404

Conversation

@mychaow
Copy link
Member

@mychaow mychaow commented Jan 4, 2021

Description

Content1 ...

Content2 ...

Content3 ...

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@mychaow mychaow added bug Something isn't working Module - Cluster PRs for the cluster module labels Jan 4, 2021
@mychaow mychaow requested review from kr11 and removed request for OneSizeFitsQuorum and jt2594838 January 4, 2021 11:21
OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 8ed7071 into apache:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

@kr11 kr11 Awaiting requested review from kr11

Assignees

No one assigned

Labels

bug Something isn't working Module - Cluster PRs for the cluster module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mychaow @OneSizeFitsQuorum