Skip to content

fix the case that column length is not right in CLI when the value contains Chinese characters#2427

Merged
HTHou merged 9 commits intoapache:masterfrom
rhmangmang:fix_column_length_not_right
Jan 6, 2021
Merged

fix the case that column length is not right in CLI when the value contains Chinese characters#2427
HTHou merged 9 commits intoapache:masterfrom
rhmangmang:fix_column_length_not_right

Conversation

@rhmangmang
Copy link
Contributor

@rhmangmang rhmangmang commented Jan 5, 2021 •
edited by HTHou
Loading

Result

Before:
image

After:
image

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

HTHou
HTHou approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!
Screen Shot 2021-01-06 at 10 08 18 AM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HTHou HTHou linked an issue Jan 6, 2021 that may be closed by this pull request
Column length is not right in CLI when the value contains Chinese #2351
Closed
@rhmangmang
Copy link
Contributor Author

rhmangmang commented Jan 6, 2021

It looks great!
Screen Shot 2021-01-06 at 10 08 18 AM

running Travis CI failed, could you run it again?

@HTHou
Copy link
Contributor

HTHou commented Jan 6, 2021

running Travis CI failed, could you run it again?

Sure.

@HTHou HTHou merged commit e2014e3 into apache:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HTHou HTHou HTHou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Column length is not right in CLI when the value contains Chinese

2 participants

@rhmangmang @HTHou