Optimize enum class and change some java practice#2435
Optimize enum class and change some java practice#2435qiaojialin merged 2 commits intoapache:masterfrom
Conversation
|
Hi, actually we are working on refactoring the TsFile module and it's almost done. Can you please help us split the modification to TsFile in this PR and submit it to the |
server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/MetadataIndexNodeType.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/TSDataType.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/TSEncoding.java
Outdated
Show resolved
Hide resolved
|
any conflict with newTsfileBranch? @HTHou |
code smell! |
Almost the using byte you mentioned. |
yuqi1129
left a comment
There was a problem hiding this comment.
@HTHou @qiaojialin
Thank you for your feedback, i will compare it with #2184 and change accordingly.
server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
Show resolved
Hide resolved
|
Hi, I checked the NewTsFile branch carefully. I found the if you change the There are two ways, one is moving the TsFile part of this PR to another PR commit into I think either way is OK. Which one would you like? |
|
@HTHou Hi, I think the former is better, it will save us a lot of time and relatively simple. |
What I mean is anything about TsFile module. The change of memtable is another optimization I think :) |
|
926c714 to
f5ed31d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Description
This PR contains no fix and feature, is about java code optimization and contains the following contents: