Skip to content

[ISSUE-2585] show devices with storage group#2475

Merged
qiaojialin merged 3 commits intoapache:masterfrom
eileenghm:show_devices_sg
Feb 7, 2021
Merged

[ISSUE-2585] show devices with storage group#2475
qiaojialin merged 3 commits intoapache:masterfrom
eileenghm:show_devices_sg

Conversation

@eileenghm
Copy link
Contributor

@eileenghm eileenghm commented Jan 12, 2021 •
edited
Loading

add new sql grammar
”show devices with storage group“

IoTDB> show devices with storage group
+--------------+-------------+
|       devices|storage group|
+--------------+-------------+
|   root.sg1.d1|     root.sg1|
|root.sg2.d1.d2|     root.sg2|
|   root.sg2.d2|     root.sg2|
+--------------+-------------+

@eileenghm eileenghm marked this pull request as draft January 12, 2021 08:32
@eileenghm eileenghm force-pushed the show_devices_sg branch 2 times, most recently from c9acfd5 to 95bc0b1 Compare January 12, 2021 08:57
@eileenghm eileenghm marked this pull request as ready for review January 12, 2021 09:42
@Alima777
Copy link
Contributor

Alima777 commented Jan 14, 2021

Hi, thank you for the contribution first :D

However, I am not sure whether we need this new feature. Literally, command show devices should not include storage group columns, and even if users want to see, they can also use show storage group command.

@eileenghm
Copy link
Contributor Author

eileenghm commented Jan 14, 2021 via email

@HTHou
Copy link
Contributor

HTHou commented Jan 15, 2021 •
edited
Loading

What about adding a new type of DDL show devices with storage group without changing the current show devices? 😂 @Alima777 @haimeiguo

@eileenghm eileenghm marked this pull request as draft January 19, 2021 06:16
@eileenghm eileenghm changed the title show devices with storage group column show devices with storage group Jan 25, 2021
@eileenghm eileenghm marked this pull request as ready for review January 25, 2021 06:38
@HTHou HTHou linked an issue Jan 26, 2021 that may be closed by this pull request
Support show devices with storage group #2585
Closed
@HTHou HTHou changed the title show devices with storage group [ISSUE-2585] show devices with storage group Jan 26, 2021
@HTHou
Copy link
Contributor

HTHou commented Jan 26, 2021

Add some user guide?

@jixuan1989
Copy link
Member

jixuan1989 commented Jan 27, 2021

code smell should be fixed: do not just return 0 directly in compareTo()

HTHou
HTHou approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried this new feature and it works very well.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HTHou
Copy link
Contributor

HTHou commented Jan 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Another code smell.... please take a look.

@qiaojialin qiaojialin merged commit f3262c6 into apache:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaojialin qiaojialin qiaojialin approved these changes

@HTHou HTHou HTHou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support show devices with storage group

5 participants

@eileenghm @Alima777 @HTHou @jixuan1989 @qiaojialin