Skip to content

Optimize the code structure of deduplicate() #2856

Merged
JackieTien97 merged 3 commits intomasterfrom
optimizeDDP
Mar 17, 2021
Merged

Optimize the code structure of deduplicate() #2856
JackieTien97 merged 3 commits intomasterfrom
optimizeDDP

Conversation

@Alima777
Copy link
Contributor

@Alima777 Alima777 commented Mar 16, 2021

The code structure of deduplicate() and internalExecuteQueryStatement() are so complex, so I optimized part of them.

  1. abstract getMemoryParametersFromPhysicalPlan() method
  2. delete redundant memory estimation in PhysicalGenerator, move it to TSServiceImpl
  3. move judgement that doesn't support nonAlignQuery to QueryPlan()

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@JackieTien97 JackieTien97 merged commit a735202 into master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants