Conversation
jt2594838
requested changes
Mar 17, 2021
server/src/main/java/org/apache/iotdb/db/query/aggregation/impl/FirstValueAggrResult.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/query/aggregation/impl/LastValueDescAggrResult.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/query/dataset/RawQueryDataSetWithValueFilter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/query/dataset/RawQueryDataSetWithValueFilter.java
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/query/reader/chunk/DiskChunkReaderByTimestamp.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/read/query/timegenerator/TimeGenerator.java
Show resolved
Hide resolved
neuyilan
reviewed
Mar 18, 2021
...r/src/main/java/org/apache/iotdb/db/query/externalsort/adapter/ByTimestampReaderAdapter.java
Show resolved
Hide resolved
Contributor
|
Hi, please fix the 26 code smells |
jt2594838
reviewed
Mar 19, 2021
server/src/main/java/org/apache/iotdb/db/query/dataset/RawQueryDataSetWithValueFilter.java
Show resolved
Hide resolved
jt2594838
approved these changes
Mar 19, 2021
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimize cluster query in following three aspects:
About the performance test result, please look at the following link:
https://shimo.im/docs/RkXYrhhvhDVcHp8C