Skip to content

[IOTDB-1260] optimize time_range query because syncMetaLeader #2929

Merged
neuyilan merged 1 commit intoapache:masterfrom
wangchao316:IOTDB-1260
Mar 29, 2021
Merged

[IOTDB-1260] optimize time_range query because syncMetaLeader #2929
neuyilan merged 1 commit intoapache:masterfrom
wangchao316:IOTDB-1260

Conversation

@wangchao316
Copy link
Copy Markdown
Member

  1. The syncMetaLeader in CMManager.getAllpath accounts for 10 percent of the performance of the query.
  2. The syncMetaLeader has been invoked in ClusterPhysicalGenerator.transformToPhysicalPlan.
  3. The possibility of metadata change is small and cannot be the bottleneck of query.
    Solution:
    remove syncMetaLeader in CMManager.getAllpath.
    test result:
    Time_Range AVG before optimization: 139.38
    Time_Ranger AVG after optimization: 110.19

@wangchao316 wangchao316 changed the title [IOTDB-1260] optimize time_ranger query [IOTDB-1260] optimize time_ranger query because syncMetaLeader Mar 27, 2021
@wangchao316
Copy link
Copy Markdown
Member Author

@LebronAl @neuyilan @mychaow @jt2594838 hi, could you please review?
Thanks

@wangchao316 wangchao316 changed the title [IOTDB-1260] optimize time_ranger query because syncMetaLeader [IOTDB-1260] optimize time_range query because syncMetaLeader Mar 27, 2021
@wangchao316 wangchao316 reopened this Mar 27, 2021
@HTHou HTHou added the Module - Cluster PRs for the cluster module label Mar 27, 2021
Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
For one query request, we can at least optimize to one syncMetaLeader per query, maybe there are still some redundant places now.

@wangchao316
Copy link
Copy Markdown
Member Author

LGTM~
For one query request, we can at least optimize to one syncMetaLeader per query, maybe there are still some redundant places now.

yes , I will I'll look elsewhere.

Copy link
Copy Markdown
Member

@neuyilan neuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neuyilan neuyilan merged commit 4b533ff into apache:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module - Cluster PRs for the cluster module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants