[IOTDB-1059] Support sql statement insert without timestamp#3067
Merged
HTHou merged 11 commits intoapache:masterfrom Jul 21, 2021
Merged
[IOTDB-1059] Support sql statement insert without timestamp#3067HTHou merged 11 commits intoapache:masterfrom
HTHou merged 11 commits intoapache:masterfrom
Conversation
Member
|
Great! |
Contributor
Author
|
Because IoTDB support create a timeseries named with time/timestamp/TIME/TIMESTAMP now, |
jixuan1989
reviewed
Jul 9, 2021
server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertRowPlan.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertRowPlan.java
Outdated
Show resolved
Hide resolved
jixuan1989
reviewed
Jul 9, 2021
server/src/main/java/org/apache/iotdb/db/qp/sql/IoTDBSqlVisitor.java
Outdated
Show resolved
Hide resolved
HTHou
reviewed
Jul 18, 2021
server/src/main/java/org/apache/iotdb/db/qp/sql/IoTDBSqlVisitor.java
Outdated
Show resolved
Hide resolved
HTHou
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1.This PR support users insert data without timestamp, the server use the current system timestamp to pair with the data points.
2.When the timeseries named with time/timestamp/TIME/TIMESTAMP, it will throw exception.
3.It doesn't support insert mult rows and will throw SQLParserException
Content1 ...
Content2 ...
Content3 ...
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR