Skip to content

[IOTDB-1059] Support sql statement insert without timestamp#3067

Merged
HTHou merged 11 commits intoapache:masterfrom
Superainbower:f_without_time
Jul 21, 2021
Merged

[IOTDB-1059] Support sql statement insert without timestamp#3067
HTHou merged 11 commits intoapache:masterfrom
Superainbower:f_without_time

Conversation

@Superainbower
Copy link
Copy Markdown
Contributor

@Superainbower Superainbower commented Apr 26, 2021

Description

1.This PR support users insert data without timestamp, the server use the current system timestamp to pair with the data points.

2.When the timeseries named with time/timestamp/TIME/TIMESTAMP, it will throw exception.

3.It doesn't support insert mult rows and will throw SQLParserException

image

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Superainbower Superainbower reopened this May 6, 2021
@qiaojialin
Copy link
Copy Markdown
Member

Great!
For the second scenario, we could report "Time/Timestamp can not be a series name, please use another name."

@Superainbower
Copy link
Copy Markdown
Contributor Author

Because IoTDB support create a timeseries named with time/timestamp/TIME/TIMESTAMP now,
So i report "should create it first" to help me judge "time/timestamp/TIME/TIMESTAMP" is a series name or not

@HTHou HTHou added the 0.13 will be released in 0.13 label May 8, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 9, 2021

Coverage Status

Coverage increased (+0.2%) to 68.108% when pulling cb8ba49 on Superainbower:f_without_time into 1616737 on apache:master.

@Superainbower Superainbower requested a review from jixuan1989 July 13, 2021 05:42
@HTHou HTHou merged commit 6e9f340 into apache:master Jul 21, 2021
@Superainbower Superainbower requested a review from HTHou July 21, 2021 08:25
sailing27 pushed a commit to sailing27/iotdb that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.13 will be released in 0.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants