Skip to content

[Cluster]No need to shake hands with itself when one node restart #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neuyilan merged 1 commit into from
Jun 16, 2021
Merged

[Cluster]No need to shake hands with itself when one node restart #3404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,10 @@ protected synchronized void startSubServers() {
/** When the node restarts, it sends handshakes to all other nodes so they may know it is back. */
private void sendHandshake() {
for (Node node : allNodes) {
if (ClusterUtils.nodeEqual(node, thisNode)) {
// no need to shake hands with yourself
continue;
}
try {
if (ClusterDescriptor.getInstance().getConfig().isUseAsyncServer()) {
AsyncMetaClient asyncClient = (AsyncMetaClient) getAsyncClient(node);
Expand Down
6 changes: 6 additions & 0 deletions cluster/src/main/java/org/apache/iotdb/cluster/utils/ClusterUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,4 +353,10 @@ public static PartitionGroup partitionByPathTimeWithSync(
}
return partitionGroup;
}

public static boolean nodeEqual(Node node1, Node node2) {
ClusterNode clusterNode1 = new ClusterNode(node1);
ClusterNode clusterNode2 = new ClusterNode(node2);
return clusterNode1.equals(clusterNode2);
}
}